Messages in this thread | | | Date | Fri, 27 Jan 2017 15:12:49 +0100 | From | Daniel Vetter <> | Subject | Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable |
| |
On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: > > On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: > > > On 01/27/2017 03:29 AM, Michel Dänzer wrote: > > > > On 26/01/17 09:46 AM, Sinclair Yeh wrote: > > > > > On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: > > > > > > Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: > > > > > > > On 01/25/2017 09:21 AM, Michel Dänzer wrote: > > > > > > > > From: Michel Dänzer <michel.daenzer@amd.com> > > > > > > > > > > > > > > > > The current caching state may not be tt_cached, even though the > > > > > > > > placement contains TTM_PL_FLAG_CACHED, because placement can contain > > > > > > > > multiple caching flags. Trying to swap out such a BO would trip up the > > > > > > > > > > > > > > > > BUG_ON(ttm->caching_state != tt_cached); > > > > > > > > > > > > > > > > in ttm_tt_swapout. > > > > > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > > > Signed-off-by: Michel Dänzer <michel.daenzer@amd.com> > > > > > > > Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com> > > > > > > Reviewed-by: Christian König <christian.koenig@amd.com>. > > > > > Reviewed-by: Sinclair Yeh <syeh@vmware.com> > > > > Thanks for the reviews! Via which tree should we merge this? > > > > > > > > > > > I don't maintain a TTM tree any longer. Let's check with Daniel if he > > > can merge it through drm-misc. > > I'm trying very hard not to get volunteered for ttm maintainer :-) > > Yeah, ok I volunteer. Wanted to take that over for a while anyway.
I guess you didn't use the dim magic to push it? The test integration tree isn't rebuild ... Quickstart for the tooling:
https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html
-Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |