lkml.org 
[lkml]   [2017]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] virtio_scsi: Add fc_host definitions
On Thu, Jan 26, 2017 at 11:41:08AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---

I pefer combining this with implementation,
hard to reason about interface alone.

> include/uapi/linux/virtio_scsi.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_scsi.h b/include/uapi/linux/virtio_scsi.h
> index cc18ef8..a26fb31 100644
> --- a/include/uapi/linux/virtio_scsi.h
> +++ b/include/uapi/linux/virtio_scsi.h
> @@ -113,6 +113,11 @@ struct virtio_scsi_config {
> __u16 max_channel;
> __u16 max_target;
> __u32 max_lun;
> + __u8 primary_wwpn[8];
> + __u8 primary_wwnn[8];
> + __u8 secondary_wwpn[8];
> + __u8 secondary_wwnn[8];
> + __u8 primary_active;

Is this in fact a binary value?
Also pls add padding to align on 8 byte boundary.

> } __attribute__((packed));
>
> /* Feature Bits */
> @@ -120,6 +125,7 @@ struct virtio_scsi_config {
> #define VIRTIO_SCSI_F_HOTPLUG 1
> #define VIRTIO_SCSI_F_CHANGE 2
> #define VIRTIO_SCSI_F_T10_PI 3
> +#define VIRTIO_SCSI_F_FC_HOST 4
>
> /* Response codes */
> #define VIRTIO_SCSI_S_OK 0
> --
> 2.9.3

\
 
 \ /
  Last update: 2017-01-26 22:50    [W:0.072 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site