lkml.org 
[lkml]   [2017]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] mm: vmscan: remove old flusher wakeup from direct reclaim path
    On Mon, Jan 23, 2017 at 01:16:39PM -0500, Johannes Weiner wrote:
    > Direct reclaim has been replaced by kswapd reclaim in pretty much all
    > common memory pressure situations, so this code most likely doesn't
    > accomplish the described effect anymore. The previous patch wakes up
    > flushers for all reclaimers when we encounter dirty pages at the tail
    > end of the LRU. Remove the crufty old direct reclaim invocation.
    >
    > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

    In general I like this. I worried first that if kswapd is blocked
    writing pages that it won't reach the wakeup_flusher_threads but the
    previous patch handles it.

    Now though, it occurs to me with the last patch that we always writeout
    the world when flushing threads. This may not be a great idea. Consider
    for example if there is a heavy writer of short-lived tmp files. In such a
    case, it is possible for the files to be truncated before they even hit the
    disk. However, if there are multiple "writeout the world" calls, these may
    now be hitting the disk. Furthermore, multiplle kswapd and direct reclaimers
    could all be requested to writeout the world and each request unplugs.

    Is it possible to maintain the property of writing back pages relative
    to the numbers of pages scanned or have you determined already that it's
    not necessary?

    --
    Mel Gorman
    SUSE Labs

    \
     
     \ /
      Last update: 2017-01-26 11:10    [W:5.073 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site