lkml.org 
[lkml]   [2017]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf probe: Ignore vmlinux build-id when offline vmlinux and dry-run used
From
Date
On 01/25/2017 08:37 PM, Masami Hiramatsu wrote:
> On Tue, 24 Jan 2017 16:41:28 -0500
> Josh Hunt <johunt@akamai.com> wrote:
>
>> Commit e50243bb ("perf probe: Ignore vmlinux Build-id when offline vmlinux given")
>> added the ability to ignore vmlinux when an offline vmlinux is passed and no
>> l, d, or a flag is also passed. This extends that to ignore build-id when
>> -n/--dry-run is used. This way we can gather probe information for offline kernels
>> using the method Brendan Gregg mentions in this post:
>> http://www.brendangregg.com/blog/2014-09-11/perf-kernel-line-tracing.html .
>
> Sorry, NAK.
> Could you use -D (--definition) for that usage? It directly gives you
> the definition on stdout, and also ignore the buildid.

Ahhh! I guess I totally missed the point of that flag. You're right. It
works exactly the way I want :)

Thanks. Please ignore my patch.

Josh

\
 
 \ /
  Last update: 2017-01-26 03:47    [W:0.251 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site