lkml.org 
[lkml]   [2017]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC] mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU
From
Date
On Wed, 2017-01-25 at 12:07 -0800, Paul E. McKenney wrote:
> On Wed, Jan 25, 2017 at 09:04:47AM -0800, Eric Dumazet wrote:

> >
> > Not clear why we need to change this very fine name ?
> >
> > SLAB_DESTROY_BY_RCU was only used by few of us, we know damn well what
> > it means.
> >
> > Consider we wont be able to change it in various web pages / archives /
> > changelogs.
>
> The reason I proposed this change is that I ran into some people last
> week who had burned some months learning that this very fine flag
> provides only type safety, not identity safety.
>
> Other proposals?

Bung hunting requires scrapping git log, in particular in areas touching
RCU (not exactly trivial stuff :) :) :) )

git log | grep SLAB_DESTROY_BY_RCU

A Google search on SLAB_DESTROY_BY_RCU finds ~4600 results.

If we rename SLAB_DESTROY_BY_RCU by XXXXXXXX, someone trying to see
prior patches or articles about XXXXXXXX mistakes will find nothing.

So please leave comments giving the old name ( SLAB_DESTROY_BY_RCU ) and
save time for future hackers.

Thanks.


\
 
 \ /
  Last update: 2017-01-25 23:46    [W:0.052 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site