Messages in this thread | | | Subject | Re: [PATCH RFC] mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU | From | Eric Dumazet <> | Date | Wed, 25 Jan 2017 14:46:17 -0800 |
| |
On Wed, 2017-01-25 at 12:07 -0800, Paul E. McKenney wrote: > On Wed, Jan 25, 2017 at 09:04:47AM -0800, Eric Dumazet wrote:
> > > > Not clear why we need to change this very fine name ? > > > > SLAB_DESTROY_BY_RCU was only used by few of us, we know damn well what > > it means. > > > > Consider we wont be able to change it in various web pages / archives / > > changelogs. > > The reason I proposed this change is that I ran into some people last > week who had burned some months learning that this very fine flag > provides only type safety, not identity safety. > > Other proposals?
Bung hunting requires scrapping git log, in particular in areas touching RCU (not exactly trivial stuff :) :) :) )
git log | grep SLAB_DESTROY_BY_RCU
A Google search on SLAB_DESTROY_BY_RCU finds ~4600 results.
If we rename SLAB_DESTROY_BY_RCU by XXXXXXXX, someone trying to see prior patches or articles about XXXXXXXX mistakes will find nothing.
So please leave comments giving the old name ( SLAB_DESTROY_BY_RCU ) and save time for future hackers.
Thanks.
| |