lkml.org 
[lkml]   [2017]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue context
    On Tue, Jan 24, 2017 at 09:02:20PM -0500, Tejun Heo wrote:
    > Hello,
    >
    > On Tue, Jan 24, 2017 at 11:54:57PM +0000, Mel Gorman wrote:
    > > @@ -2402,24 +2415,16 @@ void drain_all_pages(struct zone *zone)
    > > cpumask_clear_cpu(cpu, &cpus_with_pcps);
    > > }
    > >
    > > + for_each_cpu(cpu, &cpus_with_pcps) {
    > > + struct work_struct *work = per_cpu_ptr(&pcpu_drain, cpu);
    > > + INIT_WORK(work, drain_local_pages_wq);
    > > + schedule_work_on(cpu, work);
    > > }
    > > + for_each_cpu(cpu, &cpus_with_pcps)
    > > + flush_work(per_cpu_ptr(&pcpu_drain, cpu));
    > > +
    > > put_online_cpus();
    > > + mutex_unlock(&pcpu_drain_mutex);
    >
    > Looks good to me.
    >

    Thanks Tejun.

    --
    Mel Gorman
    SUSE Labs

    \
     
     \ /
      Last update: 2017-01-25 09:31    [W:2.358 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site