lkml.org 
[lkml]   [2017]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 19/24] media: imx: Add IC subdev drivers
From
Date


On 01/20/2017 06:29 AM, Hans Verkuil wrote:
> On 01/07/2017 03:11 AM, Steve Longerbeam wrote:
>> +
>> +static const struct v4l2_ctrl_config prpenc_std_ctrl[] = {
>> + {
>> + .id = V4L2_CID_HFLIP,
>> + .name = "Horizontal Flip",
>> + .type = V4L2_CTRL_TYPE_BOOLEAN,
>> + .def = 0,
>> + .min = 0,
>> + .max = 1,
>> + .step = 1,
>> + }, {
>> + .id = V4L2_CID_VFLIP,
>> + .name = "Vertical Flip",
>> + .type = V4L2_CTRL_TYPE_BOOLEAN,
>> + .def = 0,
>> + .min = 0,
>> + .max = 1,
>> + .step = 1,
>> + }, {
>> + .id = V4L2_CID_ROTATE,
>> + .name = "Rotation",
>> + .type = V4L2_CTRL_TYPE_INTEGER,
>> + .def = 0,
>> + .min = 0,
>> + .max = 270,
>> + .step = 90,
>> + },
>> +};
> Use v4l2_ctrl_new_std() instead of this array: this avoids duplicating information
> like the name and type.
>
> If this is also done elsewhere, then it should be changed there as well.

done.

Steve

\
 
 \ /
  Last update: 2017-01-25 03:40    [W:0.151 / U:5.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site