Messages in this thread | | | Subject | Re: fs/jffs2/readinode.c:189: faulty logic ? | From | Marek Vasut <> | Date | Tue, 24 Jan 2017 15:52:25 +0100 |
| |
On 01/24/2017 09:15 AM, David Binderman wrote: > Hello there, > > fs/jffs2/readinode.c:189]: (style) Condition 'tn.fn.ofs>=offset' is always true > > Source code is > > if (tn->fn->ofs < offset) > next = tn->rb.rb_right; > else if (tn->fn->ofs >= offset) > next = tn->rb.rb_left; > else > break; > > Maybe better code > > if (tn->fn->ofs < offset) > next = tn->rb.rb_right; > else if (tn->fn->ofs > offset) > next = tn->rb.rb_left; > else > break;
This changes the logic of the code for equality case, please elaborate why this is OK.
> Regards > > David Binderman > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ >
-- Best regards, Marek Vasut
| |