Messages in this thread | | | Subject | Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn | From | Guenter Roeck <> | Date | Sun, 22 Jan 2017 23:01:26 -0800 |
| |
On 01/22/2017 10:43 PM, Joe Perches wrote: > On Sat, 2017-01-21 at 11:20 -0800, Florian Fainelli wrote: >> We have a device reference, utilize it instead of pr_warn(). > > There is at least one more hwmon to convert in applesmc.c > > Perhaps a coccinelle script? > > Two questions for Julia Lawall: > > o is there a better way to do this than repeat the blocks > one for each replacement > o can struct device * dev be made an arbitrary identifier
Definitely yes here; otherwise you only catch the ones named 'dev'. Did you try "identifier dev;" ?
The type of fn is irrelevant; you don't need to specify it.
There is also the case where 'struct device *dev' is a local variable
fn(...) { ... struct device *dev = e; <... ...> }
or when it isn't but is still available
fn (..., struct \(platform_device\|i2c_device\|spi_device\) *pdev, ...) { }
> > $ cat dev_printk.cocci > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_emerg( > + dev_emerg(dev, > ...); > ...> > } > > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_crit( > + dev_crit(dev, > ...); > ...> > } > > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_alert( > + dev_alert(dev, > ...); > ...> > } > > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_err( > + dev_err(dev, > ...); > ...> > } > > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_notice( > + dev_notice(dev, > ...); > ...> > } > > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_warn( > + dev_warn(dev, > ...); > ...> > } > > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_info( > + dev_info(dev, > ...); > ...> > } > > @@ > identifier fn; > type T; > @@ > > T fn ( ..., struct device * dev, ... ) { > <... > - pr_debug( > + dev_dbg(dev, > ...); > ...> > } > >
| |