Messages in this thread | | | Date | Mon, 23 Jan 2017 19:52:41 +0800 | From | zhong jiang <> | Subject | Re: [PATCH] mm: do not export ioremap_page_range symbol for external module |
| |
On 2017/1/23 9:30, John Hubbard wrote: > > > On 01/22/2017 05:14 PM, zhong jiang wrote: >> On 2017/1/22 20:58, zhongjiang wrote: >>> From: zhong jiang <zhongjiang@huawei.com> >>> >>> Recently, I find the ioremap_page_range had been abusing. The improper >>> address mapping is a issue. it will result in the crash. so, remove >>> the symbol. It can be replaced by the ioremap_cache or others symbol. >>> >>> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >>> --- >>> lib/ioremap.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/lib/ioremap.c b/lib/ioremap.c >>> index 86c8911..a3e14ce 100644 >>> --- a/lib/ioremap.c >>> +++ b/lib/ioremap.c >>> @@ -144,4 +144,3 @@ int ioremap_page_range(unsigned long addr, >>> >>> return err; >>> } >>> -EXPORT_SYMBOL_GPL(ioremap_page_range); >> self nack >> > > heh. What changed your mind? > Very sorry, I mistake own kernel modules call it directly. Thank you review the patch . I will take your changelog and send it in v2.
Thanks zhongjiang > . >
| |