Messages in this thread | | | Subject | Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks | From | Andy Shevchenko <> | Date | Sat, 21 Jan 2017 15:56:20 +0200 |
| |
On Fri, 2017-01-20 at 15:58 -0800, Stephen Boyd wrote: > On 01/17, Pierre-Louis Bossart wrote: > >
> > +static void plt_clk_reg_update(struct clk_plt *clk, u32 mask, u32 > > val) > > +{ > > + u32 tmp; > > + unsigned long flags; > > + > > + spin_lock_irqsave(&clk->lock, flags); > > + > > + tmp = clk_readl(clk->reg); > > Do you need to use clk_readl? I'd prefer we deleted that > function/macro because it's just confusing.
Good to know.
> Please don't use it > unless you need it for some reason.
It was my suggestion, I didn't know that the mentioned API is kinda deprecated.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |