lkml.org 
[lkml]   [2017]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin
    Date
    Hi Andrew,

    On jeu., janv. 19 2017, Andrew Lunn <andrew@lunn.ch> wrote:

    >> While comparing the datasheet and the ops functions used, some
    >> question came to me. They should not prevent applying this series,
    >> but their answer would help me to have a better understanding of the
    >> dsa subsystem.
    >>
    >> - Are the temperature related operation still useful with dsa2 ?
    >
    > No. I'm in the process of moving the code into the Marvell PHY driver,
    > since the sensor is in the embedded PHYs.
    >
    > What ID does the embedded PHY use? The 6390 has a blank ID, where as
    > older device have a real ID.

    Actually I didn't find anything related to the temperature measurement
    in the datasheet I have. For the 6390 there is a dedicated datsheet for
    the PHY part for the 6352 it is part of the same datasheet.

    After a second look I think I don't have anything related to the PHY
    part in the datasheets.

    What I wanted to do was to test 6390 and 6352 temperature related
    functions and to see if one of them worked. That's how I realized it was
    not possible to do it with dsa2.

    >
    >> - Why the setup is done differently between the 6390 and the 6352
    >> families when the have exactly the same register?
    >
    > EDSA on 6390 works differently to 6352, meaning it breaks. So we need
    > to run the 6390 with DSA tagging, not EDSA. Maybe this is the source
    > of the differences?
    >
    > It should also be noted that the 6390 support is not yet complete. I
    > have a few more patches in my tree to post.
    >
    >> - On the Port Controller 2, the bit PORT_CONTROL_2_MAP_DA is set for
    >> 6352 and not for 6390 whereas the same bit exists in 6360 and the
    >> description for this bit is the same for both datasheet.
    >
    > Humm, it does look like it is missing mv88e6xxx_6390_family(chip).
    >
    >>
    >> - Register PORT_ATU_CONTROL and PORT_PRI_OVERRIDE are reset on 6352
    >> and not on 6390. While here again the registers description are
    >> the same.
    >
    > And the same here. I've mostly been working on where the 6390 is
    > different. Where it is the same i've mostly ignored it so far :-)
    >
    > There is also an ongoing effort to remove all these big if statements
    > with a list of families.

    Thanks for this answers I understand it a little better now.

    Gregory

    >
    > Andrew

    --
    Gregory Clement, Free Electrons
    Kernel, drivers, real-time and embedded Linux
    development, consulting, training and support.
    http://free-electrons.com

    \
     
     \ /
      Last update: 2017-01-20 18:09    [W:3.643 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site