lkml.org 
[lkml]   [2017]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross timestamps infrastructure
    From
    Date


    On 20/01/2017 13:20, Marcelo Tosatti wrote:
    > kernel/time/timekeeping.c | 79 +++++++++++++++++++++++++++++++++++++++

    Why not leave this in drivers/ptp/ptp_chardev.c?

    > + if (ptp->info->emulate_ptp_sys_offset_mean) {
    > + err = emulate_ptp_sys_offset(ptp->info, sysoff, arg);
    > + break;
    > + }

    I think this should be simply "if (!ptp->info->gettime64)" and,
    likewise, there should be an emulation based getcrosststamp in
    ptp_clock_gettime.

    Paolo

    \
     
     \ /
      Last update: 2017-01-20 14:05    [W:4.114 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site