Messages in this thread | | | Date | Mon, 2 Jan 2017 11:51:43 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH] taint/module: Fix problems when out-of-kernel driver defines true or false |
| |
On Sun 2017-01-01 20:25:25, Larry Finger wrote: > Commit 7fd8329ba502 ("taint/module: Clean up global and module taint > flags handling") used the key words true and false as character members > of a new struct. These names cause problems when out-of-kernel modules > such as VirtualBox include their own definitions of true and false. > > Fixes: 7fd8329ba502 ("taint/module: Clean up global and module taint flags handling") > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Petr Mladek <pmladek@suse.com> > Cc: Jessica Yu <jeyu@redhat.com> > Cc: Rusty Russell <rusty@rustcorp.com.au>
I like this variant a bit more than the tainted/untainted one.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |