lkml.org 
[lkml]   [2017]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 1/4] x86/ioapic: Return suitable error code in mp_map_gsi_to_irq()
    Date
    mp_map_gsi_to_irq() in some cases might return legacy -1, which would be
    wrongly interpreted as -EPERM.

    Correct those cases to return proper error code.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    arch/x86/kernel/apic/io_apic.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
    index 945e512a112a..f62c38d325da 100644
    --- a/arch/x86/kernel/apic/io_apic.c
    +++ b/arch/x86/kernel/apic/io_apic.c
    @@ -1107,12 +1107,12 @@ int mp_map_gsi_to_irq(u32 gsi, unsigned int flags, struct irq_alloc_info *info)

    ioapic = mp_find_ioapic(gsi);
    if (ioapic < 0)
    - return -1;
    + return -ENODEV;

    pin = mp_find_ioapic_pin(ioapic, gsi);
    idx = find_irq_entry(ioapic, pin, mp_INT);
    if ((flags & IOAPIC_MAP_CHECK) && idx < 0)
    - return -1;
    + return -ENODEV;

    return mp_map_pin_to_irq(gsi, idx, ioapic, pin, flags, info);
    }
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-01-19 20:26    [W:3.115 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site