Messages in this thread | | | Subject | Re: [PATCH 2/3] pinctrl: Allow configuration of pins from gpiolib based drivers | From | Andy Shevchenko <> | Date | Thu, 19 Jan 2017 14:11:22 +0200 |
| |
On Thu, 2017-01-19 at 12:48 +0300, Mika Westerberg wrote: > When a GPIO driver is backed by a pinctrl driver the GPIO driver > sometimes needs to call the pinctrl driver to configure certain > things, > like whether the pin is used as input or output. In addition to this > there are other configurations applicable to GPIOs such as setting > debounce time of the GPIO. > > To support this we introduce a new function pinctrl_gpio_set_config() > that can be used by gpiolib based driver to pass configuration > requests > to the backing pinctrl driver.
> + mutex_lock(&pctldev->mutex); > + pin = gpio_to_pin(range, gpio); > + ret = pinconf_set_config(pctldev, pin, configs, > ARRAY_SIZE(configs)); > + mutex_unlock(&pctldev->mutex);
Does gpio_to_pin() require to be under lock?
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |