lkml.org 
[lkml]   [2017]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] perf, tools: Add probing for xed
On Thu, Jan 12, 2017 at 09:39:37AM -0800, Andi Kleen wrote:
> On Thu, Jan 12, 2017 at 09:52:53AM +0100, Jiri Olsa wrote:
> > On Wed, Jan 11, 2017 at 02:17:56PM -0800, Andi Kleen wrote:
> > > > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > > > > index e3fb5ecbdcb6..971a9ef87ca6 100644
> > > > > --- a/tools/build/Makefile.feature
> > > > > +++ b/tools/build/Makefile.feature
> > > > > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC := \
> > > > > lzma \
> > > > > get_cpuid \
> > > > > bpf \
> > > > > - sdt
> > > > > + sdt \
> > > >
> > > > looks like you forgot to add xed in here? why the '\' ?
> > >
> > > I removed it, but incompletely.
> > >
> > > > anyway, please add it in here so it's visible under make VF=1
> > >
> > > If I add it here then it is shown by default (even without VF=1).
> > > Arnaldo requested earlier that it shouldn't be shown.
> >
> > if you put it to FEATURE_TESTS_BASIC then it's displayed only for VF=1
>
> It's already in FEATURE_TESTS_BASIC:
>
> @ -63,7 +63,8 @@ FEATURE_TESTS_BASIC := \
> lzma \
> get_cpuid \
> bpf \
> - sdt
> + sdt \
> + xed

I see that on FEATURE_TESTS_EXTRA in your xed-4 branch,
unless that's different to what you sent out

jirka

\
 
 \ /
  Last update: 2017-01-18 12:27    [W:0.049 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site