lkml.org 
[lkml]   [2017]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/5] perf, tools: Add one liner warning for disabled features
Date
From: Andi Kleen <ak@linux.intel.com>

Add a one liner warning for perf features that need to be enabled
explicitly by the user, so that they know they are missing something.
Currently enabled for XED and BABELTRACE.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/Makefile.config | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 9996027e7a52..39b90ffd9412 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -65,6 +65,8 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm))
NO_LIBDW_DWARF_UNWIND := 1
endif

+DISABLED_FEATURES =
+
ifeq ($(LIBUNWIND_LIBS),)
NO_LIBUNWIND := 1
endif
@@ -698,6 +700,8 @@ ifdef XED
EXTLIBS += -lxed
$(call detected,CONFIG_XED)
endif
+else
+ DISABLED_FEATURES += XED
endif

ifndef NO_LZMA
@@ -772,6 +776,8 @@ ifdef LIBBABELTRACE
else
msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
endif
+else
+ DISABLED_FEATURES += LIBBABELTRACE
endif

ifndef NO_AUXTRACE
@@ -843,6 +849,10 @@ ifdef LIBCLANGLLVM
endif
endif

+ifneq ($(DISABLED_FEATURES),)
+ $(warning Disabled features, need explicit enabling by user: $(DISABLED_FEATURES))
+endif
+
# Among the variables below, these:
# perfexecdir
# template_dir
--
2.9.3
\
 
 \ /
  Last update: 2017-01-19 02:44    [W:0.171 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site