Messages in this thread | | | Subject | Re: [RFC] HWPOISON: soft offlining for non-lru movable page | From | Yisheng Xie <> | Date | Thu, 19 Jan 2017 09:21:49 +0800 |
| |
On 2017/1/18 17:51, Michal Hocko wrote: > On Wed 18-01-17 12:00:54, Yisheng Xie wrote: >> This patch is to extends soft offlining framework to support >> non-lru page, which already support migration after >> commit bda807d44454 ("mm: migrate: support non-lru movable page >> migration") >> >> When memory corrected errors occur on a non-lru movable page, >> we can choose to stop using it by migrating data onto another >> page and disable the original (maybe half-broken) one. > > soft_offline_movable_page duplicates quite a lot from > __soft_offline_page. Would it be better to handle both cases in > __soft_offline_page? > Hi Michal, Thanks for reviewing. Yes, the most code of soft_offline_movable_page is duplicates with __soft_offline_page, I use a single function to make code looks clear, just as what soft_offline_hugetlb_page do.
I will try to make a v2 as your suggestion.
Thanks Yisheng Xie.
| |