Messages in this thread | | | Date | Tue, 17 Jan 2017 11:27:09 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: fsl-mc: fix coding stye errors |
| |
On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote: > Split line at boolean operator. > > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data' > > Signed-off-by: Dhananjay Balan <dhananjay@cliqz.com> > --- > drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > index 6b1cd57..6b19a21 100644 > --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void) > continue; > } > > - WARN_ON(mc_msi_domain-> > - host_data != &its_fsl_mc_msi_domain_info); > + WARN_ON(mc_msi_domain->host_data != > + &its_fsl_mc_msi_domain_info);
Better to line it up like this:
WARN_ON(mc_msi_domain->host_data != &its_fsl_mc_msi_domain_info);
regards, dan carpenter
| |