lkml.org 
[lkml]   [2017]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 3/4] sparc64: Add support for ADI register fields, ASIs and traps
From
From: Khalid Aziz <khalid.aziz@oracle.com>
Date: Wed, 11 Jan 2017 09:12:53 -0700

> +#define SUN4V_MCD_PRECISE \
> + ldxa [%g0] ASI_SCRATCHPAD, %g2; \
> + ldx [%g2 + HV_FAULT_D_ADDR_OFFSET], %g4; \
> + ldx [%g2 + HV_FAULT_D_CTX_OFFSET], %g5; \
> + ba,pt %xcc, etrap; \
> + rd %pc, %g7; \
> + ba,pt %xcc, sun4v_mcd_detect_precise; \
> + nop; \
> + nop;

Always indent instructions which sit in the delay slot of a non-annulled
branch, call, or jmpl by one extra space. For example:

ba,pt %xcc, 1f
nop

> +sun4v_mcd_detect_precise:
> + or %l4, %g0, %o1
> + or %l5, %g0, %o2
> + call sun4v_mem_corrupt_detect_precise
> + add %sp, PTREGS_OFF, %o0

Likewise.

Also, just do a normal "mov x, y" instead of the "or x, %g0, y" thing.

\
 
 \ /
  Last update: 2017-01-17 05:24    [W:0.171 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site