Messages in this thread | | | Subject | Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table | From | Javier Martinez Canillas <> | Date | Mon, 16 Jan 2017 09:30:14 -0300 |
| |
Hello Chanwoo,
Thanks for the review.
On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > Hi, > > I think that this patch better to squash with patch3. > After applying the patch3, this driver doesn't use > the max77686_i2c_id table. >
I usually prefer to separate each change in a different patch, AFAICT moving to use the .probe_new callback and removing the I2C id table are two different changes.
I can squash if that's the correct approach though, I will let Lee decide.
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |