lkml.org 
[lkml]   [2017]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table
From
Date
Hello Chanwoo,

Thanks for the review.

On 01/16/2017 03:46 AM, Chanwoo Choi wrote:
> Hi,
>
> I think that this patch better to squash with patch3.
> After applying the patch3, this driver doesn't use
> the max77686_i2c_id table.
>

I usually prefer to separate each change in a different patch,
AFAICT moving to use the .probe_new callback and removing the
I2C id table are two different changes.

I can squash if that's the correct approach though, I will let
Lee decide.

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

\
 
 \ /
  Last update: 2017-01-16 13:30    [W:0.426 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site