Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 15 Jan 2017 11:41:51 -0800 | Subject | Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination" |
| |
On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley <James.Bottomley@hansenpartnership.com> wrote: > > Can we compromise on "try not to revert a fix ...".
No.
It's about timing, and about how serious the regression is.
For example, if this happened in rc7, I would have reverted immediately. No questions asked.
In this case, the "fix" was was also much less important then the problem it caused. Some specialized pass-through command not working right, vs a machine not even booting? There's just no question what-so-ever.
So the "fix" you claim just wasn't nearly important enough. It was also pretty recent and clearly things had worked for _years_ without it.
In fact, I'm still somewhat inclined to revert it, just to have a working rc4 release later today. But I'm hoping maybe Ingo has time to test things (although I suspect he's already asleep).
Linus
| |