[lkml]   [2017]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 05/62] watchdog: bcm2835_wdt: Convert to use device managed functions and other improvements
Guenter Roeck <> writes:

> Use device managed functions to simplify error handling, reduce
> source code size, improve readability, and reduce the likelyhood of bugs.
> Other improvements as listed below.
> The conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts used
> to generate this commit log are available at
> - Drop assignments to otherwise unused variables
> - Replace of_iomap() with platform_get_resource() followed by
> devm_ioremap_resource()

Every time I see this pattern I wish we had a

> - Replace &pdev->dev with dev if 'struct device *dev' is a declared
> variable
> - Use devm_watchdog_register_driver() to register watchdog device
> - Replace shutdown function with call to watchdog_stop_on_reboot()

I'm trusting you here that this last change is right. All the rest of
it looks good:

Acked-by: Eric Anholt <>
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2017-01-14 07:28    [W:0.470 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site