lkml.org 
[lkml]   [2017]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support
On Fri, Jan 13, 2017 at 4:53 AM, Bard Liao <bardliao@realtek.com> wrote:
>> +static const struct acpi_gpio_mapping byt_rt5660_gpios[] = {
>> + { "audio-wake-intr-gpios", &audio_wake_intr_gpio, 1 },
>> + { "lineout-mute-gpios", &lineout_mute_gpio, 1 },
>> + { NULL },
>> +};
>> +
>
> I am thinking if it is more suitable to move the gpio params to
> machine driver? They are not codec's gpios and are only used
> by machine driver.

Generally speaking those properties should come per ACPI ID. So, they
should share the same module which has MODULE_DEVICE_TABLE(acpi, ...)
defined.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-01-13 23:30    [W:2.047 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site