lkml.org 
[lkml]   [2017]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 30/62] watchdog: mena21_wdt: Convert to use device managed functions and other improvements
> Am 11.01.2017 12:38 vorm. schrieb "Guenter Roeck" <linux@roeck-us.net>:
>
> Use device managed functions to simplify error handling, reduce
> source code size, improve readability, and reduce the likelyhood of bugs.
> Other improvements as listed below.
>
> The conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts used
> to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
>
> - Replace 'goto l; ... l: return e;' with 'return e;'
> - Drop assignments to otherwise unused variables
> - Drop remove function
> - Drop unnecessary mutex_destroy() on allocated data
> - Use devm_watchdog_register_driver() to register watchdog device
>
> Cc: Johannes Thumshirn <morbidrsa@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

Looks good,
Acked-by: Johannes Thumshirn <jth@kernel.org>

\
 
 \ /
  Last update: 2017-01-13 09:08    [W:0.357 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site