lkml.org 
[lkml]   [2017]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2 0/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip
From
Date


On 01/12/2017 10:20 PM, Keerthy wrote:
> The Davinci GPIO driver is implemented to work with one monolithic
> Davinci GPIO platform device which may have up to Y(144) gpios.
> The Davinci GPIO driver instantiates number of GPIO chips with
> max 32 gpio pins per each during initialization and one IRQ domain.
> So, the current GPIO's opjects structure is:
>
> <platform device> Davinci GPIO controller
> |- <gpio0_chip0> ------|
> ... |--- irq_domain (hwirq [0..143])
> |- <gpio0_chipN> ------|
>
> Current driver creates one chip for every 32 GPIOs in a controller.
> This was a limitation earlier now there is no need for that. Hence
> redesigning the driver to create one gpio chip for all the ngpio
> in the controller.
>
> |- <gpio0_chip0> ------|--- irq_domain (hwirq [0..143]).
>
> The previous discussion on this can be found here:
> https://www.spinics.net/lists/linux-omap/msg132869.html
>
> The series is posted on top of:
>
> https://lkml.org/lkml/2017/1/4/94
>
> Changes in v2:
>
> * Optimized the re-design patch.
> * Added couple of code clean ups after the re-design.
> * Included v2 of https://patchwork.ozlabs.org/patch/710855/
>
> Keerthy (6):
> gpio: davinci: Remove gpio2regs function to accommodate multi
> instances
> gpio: davinci: Remove unwanted blank line
> gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip
> gpio: davinci: Add support for multiple GPIO controllers
> gpio: davinci: Remove custom .xlate
> gpio: davinci: Remove redundant macros
>
> drivers/gpio/gpio-davinci.c | 174 +++++++++++++----------------
> include/linux/platform_data/gpio-davinci.h | 20 ++--
> 2 files changed, 90 insertions(+), 104 deletions(-)
>

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

--
regards,
-grygorii

\
 
 \ /
  Last update: 2017-01-13 19:03    [W:0.104 / U:1.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site