Messages in this thread | | | From | Stefano Babic <> | Subject | VME: devices not removed after commit 050c3d52cc7 | Date | Fri, 13 Jan 2017 11:03:09 +0100 |
| |
Hi,
I have updated a custom VME device driver (mainly based on vme_user.c) to 4.9 (previously it was for 3.14-).
I see that VME device drivers cannot be loaded and unloaded due to this commit:
commit 050c3d52cc7810d9d17b8cd231708609af6876ae Author: Paul Gortmaker <paul.gortmaker@windriver.com> Date: Sun Jul 3 14:05:56 2016 -0400
vme: make core vme support explicitly non-modular
In fact, this drops the remove function, that scans all devices attached to the bus and call their remove function.
That means that "remove" entry points in VME device driver (let see in drivers/staging/vme/devices/vme_user.c) are now dead code and the required cleanup code is not called at all (devices and class are not removed). Reloading the same driver cause errors due to the missing cleanup by unloading. This does not let build VME device drivers as module, as it is supposed to be done.
Paul, what do you mind ?
Best regards, Stefano Babic
-- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================
| |