lkml.org 
[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/9] mm/swap: Split swap cache into 64MB trunks
On Wed, Jan 11, 2017 at 03:19:37PM -0800, Andi Kleen wrote:
> > Switching from a single radix-tree to an array of radix-trees to reduce
> > contention seems a bit hacky. That we can do this and have everything
> > continue to work tells me that we're simply using an inappropriate data
> > structure to hold this info.
>
> What would you use instead?

I agree that this approach is a bit hacky. However, it is pretty
effective and simple. If later on we come up with a better solution to
scale modfication of the radix tree, we can collapse the radix trees.

I think developing a scalable radix tree with write modifications will
take quite a while and is a non-trivial effort. With almost memory speed
SSDs coming on the market soon, I think having a workable solution now
and optimizing it for long term is reasonabale.

Tim

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-01-12 17:48    [W:0.084 / U:3.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site