lkml.org 
[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 7/7] uapi: export all headers under uapi directories
    From
    Date
    Le 09/01/2017 à 13:56, Christoph Hellwig a écrit :
    > On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote:
    >> Regularly, when a new header is created in include/uapi/, the developer
    >> forgets to add it in the corresponding Kbuild file. This error is usually
    >> detected after the release is out.
    >>
    >> In fact, all headers under uapi directories should be exported, thus it's
    >> useless to have an exhaustive list.
    >>
    >> After this patch, the following files, which were not exported, are now
    >> exported (with make headers_install_all):
    >
    > ... snip ...
    >
    >> linux/genwqe/.install
    >> linux/genwqe/..install.cmd
    >> linux/cifs/.install
    >> linux/cifs/..install.cmd
    >
    > I'm pretty sure these should not be exported!
    >
    Those files are created in every directory:
    $ find usr/include/ -name '\.\.install.cmd' | wc -l
    71
    $ find usr/include/ -name '\.install' | wc -l
    71

    See also
    http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/Makefile.headersinst#n32


    Thank you,
    Nicolas

    \
     
     \ /
      Last update: 2017-01-12 16:54    [W:3.870 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site