lkml.org 
[lkml]   [2017]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/9] dma: Add dma_virt_ops
From
Date
On 01/11/2017 12:56 AM, Christoph Hellwig wrote:
>> +lib-$(CONFIG_HAS_DMA) += dma-virt.o
>
> There probably should be a config option for it for two reasons:
>
> - do not bloat kernels that don't need it.
> - the feature can only work for 32-bit architectures or for
> 64-bit architectures that set ARCH_DMA_ADDR_T_64BIT…
> Alternatively this option would have to force
> ARCH_DMA_ADDR_T_64BIT when not yet set for 64-bit architectures.
>
> And yes, this is currently broken already for, but we'd better fix it.

Hello Christoph,

That sounds like a good idea to me. I will make sure that both
dma_noop_ops and dma_virt_ops are only built if needed.

Bart.

\
 
 \ /
  Last update: 2017-01-12 01:08    [W:0.083 / U:22.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site