[lkml]   [2017]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] pinctrl: qcom: Add msm8998 pinctrl driver
On Mon, Jan 9, 2017 at 4:00 PM, Imran Khan <> wrote:

> Add initial pinctrl driver to support pin configuration with
> pinctrl framework for msm8998.
> Signed-off-by: Imran Khan <>

You need review from the Qcom pinctrl maintainer Bjorn Andersson
for this patch.

+#define NORTH 0x500000
+#define WEST 0x100000
+#define EAST 0x900000
> +static const struct msm_pingroup msm8998_groups[] = {
> + PINGROUP(0, EAST, blsp_spi1, blsp_uart1_a, blsp_uim1_a, NA, NA, NA, NA,
> + PINGROUP(6, WEST, blsp_spi8, blsp_uart8_a, blsp_i2c8, NA, NA, NA, NA,
> + PINGROUP(35, NORTH, pci_e0, jitter_bist, NA, NA, NA, NA, NA, NA, NA),

No south? :)

Are these the left/right/top edges of the chip or a reference
to x86 bridges terminology? It warrants that you add a comment
to the driver file explaining what it means.

Linus Walleij

 \ /
  Last update: 2017-01-11 16:13    [W:0.055 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site