lkml.org 
[lkml]   [2017]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board
From
Date


On 01/11/2017 06:39 PM, Andrzej Hajda wrote:
> On 11.01.2017 09:40, Inki Dae wrote:
>> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글:
>>> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>>>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>>>
>>>> This patch add the panel device tree node for S6E3HA2 display
>>>> controller to TM2 dts.
>>>>
>>>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>>>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>> ---
>>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>> index ddba2f8..6d362f9 100644
>>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>> @@ -18,6 +18,18 @@
>>>> compatible = "samsung,tm2", "samsung,exynos5433";
>>>> };
>>>>
>>>> +&dsi {
>>>> + panel@0 {
>>>> + compatible = "samsung,s6e3ha2";
>>>> + reg = <0>;
>>>> + vdd3-supply = <&ldo27_reg>;
>>>> + vci-supply = <&ldo28_reg>;
>>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
>>> The same here (as in 1st comment) , te-gpios should be dropper - decon
>>> uses hw-trigger.
>> Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together.
>>
>> Thanks.
> OK, I forgot it was not yet ported to mainline.
>
> Regards
> Andrzej

I received a reply while I was writing the mail.
so, how about removing te-gpios later?

Best Regards,
Hoegeun

>
>>> Regards
>>> Andrzej
>>>> + };
>>>> +};
>>>> +
>>>> &hsi2c_9 {
>>>> status = "okay";
>>>>
>>>
>>>
>
>

\
 
 \ /
  Last update: 2017-01-11 11:24    [W:0.091 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site