Messages in this thread | | | Subject | Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() | From | Paolo Bonzini <> | Date | Tue, 10 Jan 2017 10:39:21 +0100 |
| |
On 10/01/2017 06:09, Peter Xu wrote: >> Was wondering if FULL/SPLIT would be a better naming. However I also >> find irqchip_kernel() vs irqchip_in_kernel() slightly confusing. > Me too. Since we have kvm_irqchip_mode enum above, how about renaming > irqchip_{kernel|split}() into irqchip_mode_{kernel|split}()? > > Sorry for such a late comment...
No problem, it can be done on top.
Another thing to do is to make irqchip_in_kernel check mode != NONE.
Paolo
| |