Messages in this thread | | | Subject | Re: [PATCH 0/2] Style fixes: open code obfuscating macros | From | Joe Perches <> | Date | Tue, 10 Jan 2017 15:06:52 -0800 |
| |
On Tue, 2017-01-10 at 16:59 -0500, Jon Mason wrote: > On Tue, Jan 10, 2017 at 4:55 PM, Jon Mason <jdmason@kudzu.us> wrote: > > On Mon, Jan 02, 2017 at 06:30:34PM -0700, Logan Gunthorpe wrote: > > > Hi, > > > > > > I had copied some poor code style from the NTB drivers into an unrelated > > > driver. Upon review of my new code, I learned it was not a good idea > > > to sweep dirty things under the rug^W macro. See [1], where Gregg k-h > > > suggested I fix the problem at the source. > > > > > > Thus, please merge the following two patches to improve the style of > > > the NTB drivers. > > > > > > Thanks, > > > > > > Logan > > > > Applying the series, thanks > > Gaaa, these don't apply cleanly. Can you rebase on my > https://github.com/jonmason/ntb (branch ntb) and resubmit?
It might also be better to add and use YA logging macro like ndev_dbg
#define ndev_dvg(ndev, fmt, ...) \ dev_dbg(&(ndev)->ntb.pdev->dev, fmt, ##__VA_ARGS__)
so that the new temporaries that are used just for debugging are not required.
| |