lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests/futex: Fix makefile dependencies
On Tue, Jan 10, 2017 at 02:10:42PM -0800, Darren Hart wrote:
> On Fri, Jan 06, 2017 at 01:18:39PM +0900, Stafford Horne wrote:
> > I am working on doing selftests for openrisc and found issues with the
> > futex test is not building after changes to the tests source.
> >
> > This issue is that the TARGETS variable used in the futex Makefile is
> > also used by the selftests Makefile, so when building from toplevel the
> > TARGETS variable is clobbered and nothing gets built. Changed the
> > variable name to get around that.
> >
> > Also, the futex makefile did not contain dependencies for all headers,
> > so if we make changes to logging.h rebuild will not happen. Add headers
> > to fix it up.
> >
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
>
> Thanks for catching this and the fix.
>
> +Shuah Khan
>
> Note: This appears also to be a problem for intel_pstate/Makefile

Or, it would be if intel_pstate was listed in selftests/Makefile :-)
--
Darren Hart
Intel Open Source Technology Center

\
 
 \ /
  Last update: 2017-01-10 23:18    [W:0.066 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site