Messages in this thread | | | Date | Fri, 9 Sep 2016 16:23:58 +0800 | From | Phidias Chiang <> | Subject | Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe |
| |
On Fri, Sep 09, 2016 at 09:18:34AM +0300, Mika Westerberg wrote: > On Fri, Sep 09, 2016 at 12:28:43AM +0800, Phidias Chiang wrote: > > Hmm, how can that happen? The patch removes clearing of INTMASK and only > other place where it is cleared temporarily is on resume. Can you add > dev_info() calls like: > > /* Clear all interrupts */ > chv_writel(0xffff, pctrl->regs + CHV_INTSTAT); > dev_info(pctrl->dev, "INTMASK0: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK)); > > ... > > gpiochip_set_chained_irqchip(chip, &chv_gpio_irqchip, irq, > chv_gpio_irq_handler); > dev_info(pctrl->dev, "INTMASK1: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK)); > return 0; > > It should print the same values both time. > > Also which interrupt does not work and can you send me output of > /proc/interrupts?
Output in dmesg: [ 2.054475] cherryview-pinctrl INT33FF:00: INTMASK0: 0x00000006 [ 2.055247] cherryview-pinctrl INT33FF:00: INTMASK1: 0x00000000 [ 2.055375] cherryview-pinctrl INT33FF:01: INTMASK0: 0x00004000 [ 2.056931] cherryview-pinctrl INT33FF:01: INTMASK1: 0x00000000 [ 2.057036] cherryview-pinctrl INT33FF:02: INTMASK0: 0x00000000 [ 2.057367] cherryview-pinctrl INT33FF:02: INTMASK1: 0x00000000 [ 2.057489] cherryview-pinctrl INT33FF:03: INTMASK0: 0x00000000 [ 2.058337] cherryview-pinctrl INT33FF:03: INTMASK1: 0x00000000
So it's somehow got cleared in the process after.
And the following link is the complete /proc/interrupts: http://pastebin.com/qwamyKZb
THe interrupt doesn't work is 9, when I made it work it responsed to pressing hotkeys.
| |