Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Thu, 8 Sep 2016 14:29:11 +0200 | Subject | Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent |
| |
2016-09-08 14:27 GMT+02:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote: >> The register offset defines for the pca953x and pca957x expander >> families should have the same names to better reflect their similar >> purposes. > > > > >> chip->regs = &pca957x_regs; >> >> - ret = pca953x_read_regs(chip, PCA957X_OUT, chip->reg_output); >> + ret = pca953x_read_regs(chip, PCA957X_OUTPUT, chip- >> >reg_output); >> if (ret) >> goto out; >> - ret = pca953x_read_regs(chip, PCA957X_CFG, chip- >> >reg_direction); >> + ret = pca953x_read_regs(chip, PCA957X_DIRECTION, chip- >> >reg_direction); > > Bu we may use chip->regs->direction here, right? And output before. >
Yes, though it should go into patch 1/6.
Thanks, Bartosz
| |