lkml.org 
[lkml]   [2016]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] usercopy fixes for v4.8-rc6-part2
On Wed, Sep 7, 2016 at 11:36 AM, Kees Cook <keescook@chromium.org> wrote:
>
> - move page-spanning check behind a CONFIG since it's triggering false positives

Hmm. I pulled this, but looking at it I realized that

+ depends on !COMPILE_TEST

doesn't make any real sense to me.

All it does is make sure that "make allmodconfig" doesn't actually
test that the PAGESPAN code compiles.

It's not like that is a big cost for allmodconfig builds, but it does
mean that it gets less coverage.

And it really makes no sense to me. We *don't* want to run with that
option enabled normally.

I think what you actually meant was something like

+ depends on EXPERT

which means that it does *not* get enabled in normal user builds.

Hmm?

Linus

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.047 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site