Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 7 Sep 2016 16:15:20 +0200 | Subject | Re: [PATCH 1/5] gpio: pca954x: fix undefined error code from remove |
| |
On Fri, Aug 26, 2016 at 5:25 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The recent addition of the regulator support has led to the pca953x_remove > function returning uninitialized data when no platform data pointer is > provided, as gcc warns when using -Wmaybe-uninitialized: > > drivers/gpio/gpio-pca953x.c: In function 'pca953x_remove': > drivers/gpio/gpio-pca953x.c:860:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This restores the previous behavior, returning 0 on success. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: e23efa311110 ("gpio: pca954x: Add vcc regulator and enable it") > Cc: Phil Reid <preid@electromag.com.au> > --- > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: linux-gpio@vger.kernel.org
Patch applied with Phil's ACK.
Yours, Linus Walleij
| |