lkml.org 
[lkml]   [2016]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/2] lan78xx: Remove trailing underscores from macros
    From
    Date
    On Tue, 2016-09-06 at 23:19 +0000, Woojung.Huh@microchip.com wrote:
    > > Joe Perches (2):
    > >   lan78xx: Remove locally defined trailing underscores from defines and uses
    > >   microchipphy.h and uses: Remove trailing underscores from defines and
    > > uses
    > >
    > >  drivers/net/phy/microchip.c | 4 +-
    > >  drivers/net/usb/lan78xx.c | 368 +++++++--------
    > >  drivers/net/usb/lan78xx.h | 1068 +++++++++++++++++++++-----------------
    > > ----
    > >  include/linux/microchipphy.h | 72 +--
    > >  4 files changed, 756 insertions(+), 756 deletions(-)
    >
    >
    > Because there is no specific rule how to name defines, I'm not sure it is worth to change 1000+ lines.
    > It may be better to set guideline for new submissions.
    >
    > Welcome any comments.

    Generally, more conforming to norms is better.
    These FOO_ uses are non-conforming.

    Is there anything other than a one-time cost
    to apply these? Is the same code used for
    other platforms?

    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:3.809 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site