Messages in this thread | | | Subject | Re: [RFC PATCH V5 2/5] PCI/ACPI: Move ACPI ECAM mapping to generic MCFG driver | From | Tomasz Nowicki <> | Date | Tue, 6 Sep 2016 20:04:05 +0200 |
| |
On 05.09.2016 04:22, Bjorn Helgaas wrote: > On Mon, Aug 08, 2016 at 03:05:38PM +0200, Tomasz Nowicki wrote: >> pci_acpi_setup_ecam_mapping() is not really ARM64 specific so move it out >> of arch/arm64/ directory. In preparation for adding MCFG quirk handling >> extend pci_acpi_setup_ecam_mapping() functionality to accept custom >> PCI config accessors (function's argument). >> >> For ARM64 ACPI based PCI host controller we still use pci_generic_ecam_ops. > > I'm not sure we gain much by moving pci_acpi_setup_ecam_mapping() from > arm64 code to generic code, since nobody else uses it yet. But if you > do want to move it, can you do the move (with no other change at all) > in one patch, and add the new "ops" argument in a second patch? I > just don't want the "ops" change to get lost in the noise of the move.
Yes, will do.
Tomasz
| |