Messages in this thread | | | Date | Mon, 5 Sep 2016 23:24:35 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] nvme-rdma: fix null pointer dereference on req->mr |
| |
On Mon, Sep 05, 2016 at 04:24:38PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > If there is an error on req->mr, req->mr is set to null, however > the following statement sets req->mr->need_inval causing a null > pointer dereference. Fix this by bailing out to label 'out' to > immediately return and hence skip over the offending null pointer > dereference. > > Fixes: f5b7b559e1488 ("nvme-rdma: Get rid of duplicate variable") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |