lkml.org 
[lkml]   [2016]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered
    On Tue, 16 Aug 2016, Pratyush Anand wrote:

    That's a lot of churn to fix that simple problem. The two liner below
    should fix that as well, right?

    Thanks,

    tglx

    diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
    index 43745cac0141..cb8dfc3ee012 100644
    --- a/drivers/rtc/rtc-cmos.c
    +++ b/drivers/rtc/rtc-cmos.c
    @@ -707,6 +707,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
    goto cleanup1;
    }

    + hpet_rtc_timer_init();
    if (is_valid_irq(rtc_irq)) {
    irq_handler_t rtc_cmos_int_handler;

    @@ -714,6 +715,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
    rtc_cmos_int_handler = hpet_rtc_interrupt;
    retval = hpet_register_irq_handler(cmos_interrupt);
    if (retval) {
    + hpet_mask_rtc_irq_bit(RTC_IRQMASK);
    dev_warn(dev, "hpet_register_irq_handler "
    " failed in rtc_init().");
    goto cleanup1;
    @@ -729,7 +731,6 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
    goto cleanup1;
    }
    }
    - hpet_rtc_timer_init();

    /* export at least the first block of NVRAM */
    nvram.size = address_space - NVRAM_OFFSET;

    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:2.773 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site