lkml.org 
[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform
    From
    Date


    從我的 iPad 傳送

    > David Laight <David.Laight@ACULAB.COM> 於 2016年9月5日 下午9:35 寫道:
    >
    > From: Randy Li
    >> Sent: 03 September 2016 22:55
    > ...
    >> + if (of_device_is_compatible(np, "rockchip,rk3288-usb")
    >> + && (NULL != hsotg->phy->ops->reset))
    >> + hsotg->phy->ops->reset(hsotg->phy);
    >> +
    >
    > Is this the only place ops->reset() is called?
    Yes.
    > Probably much better to check it first.
    Sure.
    >
    > if (hsotg->phy->ops->reset
    > && of_device_is_compatible(np, "rockchip,rk3288-usb")
    > hsotg->phy->ops->reset(hsotg->phy);
    I see, if there is no the other review request for this version, I would submit a new version to fix this problem tonight.
    >
    > David

    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:5.348 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site