lkml.org 
[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC
Date
On Monday, September 05, 2016 09:11:47 AM Quentin Schulz wrote:
> On 05/09/2016 09:07, Maxime Ripard wrote:
> > Hi,
> >
> > Nitpicks ahead.
> >
> > On Thu, Sep 01, 2016 at 04:05:05PM +0200, Quentin Schulz wrote:
> >> + info->soc_specific = (struct soc_specific *)platform_get_device_id(pdev)->driver_data;
> >
> > This line is still rather long. How about calling the field "data" and
> > the structure gpadc_data?
> >
>
> driver_data is coming from the platform_device_id
> (http://lxr.free-electrons.com/source/include/linux/mod_devicetable.h#L498)
> so can't really change that.
> I could change the structure to gpadc_data, that would save me 2
> characters, still 13 characters above the 80 characters limit however.
>
I think Maxime meant to change member "soc_specific" to "data" of type
struct gpadc_data

> >> +
> >> + tzd = devm_thermal_zone_of_sensor_register(pdev->dev.parent, 0, info,
> >> + &sun4i_ts_tz_ops);
> >
> > A comment on why you put the parent device structure and not the
> > device itself like you're doing on all the other calls in that probe
> > would be nice.
> >
>
> Indeed.
>
> Thanks,
> Quentin
>
> > Thanks!
> > Maxime
> >
>

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.046 / U:1.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site