lkml.org 
[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.7 057/143] perf tools mem: Fix -t store option for record command
    Date
    4.7-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiri Olsa <jolsa@kernel.org>

    commit 33da54fa86e29b87fe1e83bd0f15b4ef2be53ecb upstream.

    Michael reported 'perf mem -t store record' being broken. The reason is
    latest rework of this area:

    commit acbe613e0c03 ("perf tools: Add monitored events array")

    We don't mark perf_mem_events store record when -t store option is
    specified.

    Committer notes:

    Before:

    # perf mem -t store record usleep 1
    [ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 0.020 MB perf.data (7 samples) ]
    # perf evlist
    cycles:ppp
    #

    After:

    # perf mem -t store record usleep 1
    [ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 0.020 MB perf.data (7 samples) ]
    # perf evlist
    cpu/mem-stores/P
    #

    Reported-by: Michael Petlan <mpetlan@redhat.com>
    Signed-off-by: Jiri Olsa <jolsa@redhat.com>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Fixes: acbe613e0c03 ("perf tools: Add monitored events array")
    Link: http://lkml.kernel.org/r/1470905457-18311-1-git-send-email-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/perf/builtin-mem.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/tools/perf/builtin-mem.c
    +++ b/tools/perf/builtin-mem.c
    @@ -87,6 +87,9 @@ static int __cmd_record(int argc, const
    if (mem->operation & MEM_OPERATION_LOAD)
    perf_mem_events[PERF_MEM_EVENTS__LOAD].record = true;

    + if (mem->operation & MEM_OPERATION_STORE)
    + perf_mem_events[PERF_MEM_EVENTS__STORE].record = true;
    +
    if (perf_mem_events[PERF_MEM_EVENTS__LOAD].record)
    rec_argv[i++] = "-W";


    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:5.036 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site