Messages in this thread | | | Date | Mon, 5 Sep 2016 09:53:05 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/4] perf/x86/cqm: Replace two kmalloc() calls by kmalloc_array() in intel_mbm_init() |
| |
On Sun, Sep 04, 2016 at 07:56:30PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 4 Sep 2016 18:25:09 +0200 > > 1. A multiplication for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use the corresponding function "kmalloc_array". > > 2. Replace the specification of a data structure by pointer dereferences > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > 3. Delete the local variable "array_size" which became unnecessary > with this refactoring.
3 is an admission you made the code worse in absense of other improvements.
| |