Messages in this thread | | | From | Amit Ghadge <> | Date | Sun, 4 Sep 2016 15:45:02 +0530 | Subject | Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check. |
| |
I will be send individual patches.
I was try, make M=drivers/staging/comedi/
No issue generated, Is there have any other option to test these changes?
Amit G
On Sun, Sep 4, 2016 at 2:05 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote: >> Fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid >> of checkpatch.pl "CHECK" output "Prefer using the BIT macro". >> Replace Avoid CamelCase range_0_20mA to range_0_20ma. > > That's multiple things in the same patch, and you didn't even test build > your change :( > > Please do better than this in the future. > > greg k-h
| |