lkml.org 
[lkml]   [2016]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
On Thu, Sep 29, 2016 at 11:37 PM, Jun Li <jun.li@nxp.com> wrote:
> Hi Guenter,
>> -----Original Message-----
>> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-
>> owner@vger.kernel.org] On Behalf Of Guenter Roeck
>> Sent: Wednesday, August 24, 2016 5:11 AM
>> To: Felipe Balbi <felipe.balbi@linux.intel.com>
>> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; Bruce
>> Ashfield <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>;
>> Pranav Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus
>> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux-
>> usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org>
>> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
>>
> ...
>> diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h
>> new file mode 100644
>> index 000000000000..6b1679af7a25
>> --- /dev/null
>> +++ b/include/linux/usb/pd.h
>
> ...
>
>> +#define PDO_VAR(min_mv, max_mv, max_ma) \
>> + ((PDO_TYPE_VAR << PDO_TYPE_SHIFT) | \
>> + ((((min_mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << \
>> + PDO_VAR_MIN_VOLT_SHIFT) | \
>> + ((((max_mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << \
>> + PDO_VAR_MAX_VOLT_SHIFT) | \
>> + ((((max_ma) / 50) & PDO_VAR_MAX_CURR_MASK) << \
>
> ((((max_ma) / 10) & PDO_VAR_MAX_CURR_MASK) << \
>

Thanks, fixed. PDO_BATT has a similar problem, which I noticed while
fixing the above.

Guenter

\
 
 \ /
  Last update: 2016-09-30 21:06    [W:0.137 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site